Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up quotient APIs #16210

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

Clean up quotient APIs #16210

wants to merge 17 commits into from

Conversation

FR-vdash-bot
Copy link
Collaborator

@FR-vdash-bot FR-vdash-bot commented Aug 28, 2024

@FR-vdash-bot FR-vdash-bot added the t-data Data (lists, quotients, numbers, etc) label Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

PR summary aa203fbe8c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Quot.surjective_mk
+ Quotient.coe_smul_out
+ Quotient.hrecOn_mk
+ Quotient.hrecOn₂_mk
+ Quotient.mk_smul_out
+ Quotient.surjective_liftOn
+ Quotient.surjective_mk
+ Quotient.surjective_mk'
+ _root_.QuotientGroup.out_conj_pow_minimalPeriod_mem
+ acc_liftOn₂_iff
+ decidableRel
+ equiv_iff_apply
+ ext'_iff
+ instance (q : Quotient sa) (f : α → Prop) (h : ∀ a b, sa a b → f a = f b) [DecidablePred f] :
+ instance : CoeFun (Setoid α) (fun _ ↦ α → α → Prop)
+ instance : Inhabited (ValueGroup A K) := ⟨⟦0⟧⟩
+ instance : One (HomogeneousLocalization 𝒜 x) where one := ⟦1⟧
+ instance : One (ValueGroup A K) := ⟨⟦1⟧⟩
+ instance : Zero (HomogeneousLocalization 𝒜 x) where zero := ⟦0⟧
+ instance : Zero (ValueGroup A K) := ⟨⟦0⟧⟩
+ instance [r : Setoid α] [h : DecidableRel (α := α) (· ≈ ·)] : DecidableRel r
+ instance {α : Type*} (s : Setoid α) : IsEquiv α s
+ measurable_quotient_mk
+ quotMk_eq_coe
+ range_quotient_liftOn
++ out_eq
+-+- mk
+-+- mk_surjective
+--+ map
+--- out_eq'
- Setoid.decidableRel
- ext_iff
- instance (q : Quotient sa) (f : α → Prop) (h : ∀ a b, a ≈ b → f a = f b) [DecidablePred f] :
- instance (q : Quotient s₁) (f : α → Prop) (h : ∀ a b, @Setoid.r α s₁ a b → f a = f b)
- instance (q₁ : Quotient s₁) (q₂ : Quotient s₂) (f : α → β → Prop)
- instance : Inhabited (ValueGroup A K) := ⟨Quotient.mk'' 0⟩
- instance : One (HomogeneousLocalization 𝒜 x) where one := Quotient.mk'' 1
- instance : One (ValueGroup A K) := ⟨Quotient.mk'' 1⟩
- instance : Zero (HomogeneousLocalization 𝒜 x) where zero := Quotient.mk'' 0
- instance : Zero (ValueGroup A K) := ⟨Quotient.mk'' 0⟩
-+-+ mk''_eq_mk
--++ stabilizerEquivStabilizerOfOrbitRel
--- argument.

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@FR-vdash-bot
Copy link
Collaborator Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit c0d07be.
The entire run failed.
Found no significant differences.

@FR-vdash-bot
Copy link
Collaborator Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 4ae7e83.
There were no significant changes against commit e5cd4b4.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Aug 29, 2024
@FR-vdash-bot FR-vdash-bot added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Aug 29, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-data Data (lists, quotients, numbers, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants